chore(test): add test cases for getIPsFromString#8433
Merged
dshekhar95 merged 4 commits intomainfrom Dec 7, 2022
Merged
Conversation
dshekhar95
requested review from
akon-dey,
darkn3rd,
gcxml,
meghalims and
skrdgraph
as code owners
dshekhar95
changed the title
dshekhar95
commented
Nov 15, 2022
MichelDiz
approved these changes
Nov 21, 2022
matthewmcneely
approved these changes
Dec 5, 2022
Contributor
matthewmcneely
left a comment
matthewmcneely
left a comment
There was a problem hiding this comment.
Approved (following the format revert in run_test.go)
reverting unintended change
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
test cases missing for getIPsFromString
Solution
add test for empty string, error cases