fix(GRAPHQL): fix empty remove in update mutation patch, that remove all the data for nodes in filter.#7563
Merged
JatinDev543 merged 4 commits intorelease/v21.03from Mar 15, 2021
Merged
Conversation
github-actions
Bot
added
the
area/graphql
vmrajas
approved these changes
Mar 15, 2021
aman-bansal
pushed a commit
that referenced
this pull request
Mar 16, 2021
…all the data for nodes in filter. (#7563) We have this behavior of update mutation where we are deleting all the data for nodes that are selected in the filter when we give empty remove {} in the update patch. For example in the below case , we delete everything for node with id 0x123 mutation updateAuthor($patch: UpdateAuthorInput!) { updateAuthor(input: $patch) { author { id } } } variables: { "patch": { "filter": { "id": ["0x123"] }, "remove": {} } } This can be more dangeours if we apply filter also empty like below, in that case it will delete every node of type Author. { "patch": { "filter": { "id": ["0x123"] }, "remove": {} } We are now changing this behaviour , such that empty remove{}, doesn't have any effect.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have this behavior of update mutation where we are deleting all the data for nodes that are selected in the filter when we give empty remove {} in the update patch.
For example in the below case , we delete everything for node with id 0x123
variables:
This can be more dangeours if we apply filter also empty like below, in that case it will delete every node of type Author.
We are now changing this behaviour , such that empty remove{}, doesn't have any effect.
This change is