Skip to content

fix(readPostingList): Return error instead of panic #5877

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jarifibrahim merged 1 commit into from
Jul 9, 2020
Merged

fix(readPostingList): Return error instead of panic #5877

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion posting/mvcc.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -317,7 +317,9 @@ func ReadPostingList(key []byte, it *badger.Iterator) (*List, error) {
case BitDeltaPosting:
err := item.Value(func(val []byte) error {
pl := &pb.PostingList{}
x.Check(pl.Unmarshal(val))
if err := pl.Unmarshal(val); err != nil {
return err
}
pl.CommitTs = item.Version()
for _, mpost := range pl.Postings {
// commitTs, startTs are meant to be only in memory, not
Expand Down