Skip to content

Adding more details for mutation error messages with scalar/uid type mismatch #4317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
prashant-shahi merged 2 commits into from
Nov 26, 2019
Merged

Adding more details for mutation error messages with scalar/uid type mismatch #4317

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a138fce
Adding more details for error messages with scalar/uid type mismatch
prashant-shahi Nov 25, 2019
ccb7172
used %q instead of "%s"
prashant-shahi Nov 25, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions worker/mutation.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -349,10 +349,10 @@ func ValidateAndConvert(edge *pb.DirectedEdge, su *pb.SchemaUpdate) error {
return nil

case !schemaType.IsScalar() && storageType.IsScalar():
return errors.Errorf("Input for predicate %s of type uid is scalar", edge.Attr)
return errors.Errorf("Input for predicate %q of type uid is scalar. Edge: %v", edge.Attr, edge)

case schemaType.IsScalar() && !storageType.IsScalar():
return errors.Errorf("Input for predicate %s of type scalar is uid. Edge: %v", edge.Attr, edge)
return errors.Errorf("Input for predicate %q of type scalar is uid. Edge: %v", edge.Attr, edge)

// The suggested storage type matches the schema, OK!
case storageType == schemaType && schemaType != types.DefaultID:
Expand Down