release/v1.2: fix(readPostingList): Return error instead of panic (#5877)#5908
Merged
parasssh merged 2 commits intorelease/v1.2from Jul 13, 2020
Merged
release/v1.2: fix(readPostingList): Return error instead of panic (#5877)#5908parasssh merged 2 commits intorelease/v1.2from
parasssh merged 2 commits intorelease/v1.2from
Conversation
We've seen some panics like "proto: illegal wireType 6" on trying to read the posting lists. We haven't found the fix yet. The issue could be because badger is returning incorrect values for the posting list. Since we haven't been able to reproduce it, this is a stop-gap solution to return an error instead of crashing dgraph. This is not the fix, this will return an error instead of causing a panic. Fixes DGRAPH-1778 (cherry picked from commit f2773c8)
martinmr
approved these changes
Jul 13, 2020
Contributor
martinmr
left a comment
martinmr
left a comment
There was a problem hiding this comment.
Reviewable status: 0 of 1 files reviewed, all discussions resolved (waiting on @manishrjain and @martinmr)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We've seen some panics like "proto: illegal wireType 6" on trying to read the
posting lists. We haven't found the fix yet. The issue could be because badger
is returning incorrect values for the posting list. Since we haven't been able
to reproduce it, this is a stop-gap solution to return an error instead of
crashing dgraph.
This is not the fix, this will return an error instead of
causing a panic.
Fixes DGRAPH-1778
(cherry picked from commit f2773c8)
This change is
Docs Preview: