Skip to content

Adding more details for mutation error messages with scalar/uid type mismatch#4317

Merged
prashant-shahi merged 2 commits into
masterfrom
prashant/error-reformatting
Nov 26, 2019
Merged

Adding more details for mutation error messages with scalar/uid type mismatch#4317
prashant-shahi merged 2 commits into
masterfrom
prashant/error-reformatting

Conversation

@prashant-shahi
Copy link
Copy Markdown
Contributor

@prashant-shahi prashant-shahi commented Nov 25, 2019

Fixes dgraph-io/dgraph-js#61

  • Adding quotes around the predicate name
  • Adding edge in the error message

This change is Reviewable

@prashant-shahi prashant-shahi requested a review from a team November 25, 2019 15:21
Copy link
Copy Markdown
Contributor

@campoy campoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @manishrjain and @prashant-shahi)


worker/mutation.go, line 352 at r1 (raw file):

"%s"

You should use %q instead, that will add the quotes and escape any special characters.

Copy link
Copy Markdown
Contributor Author

@prashant-shahi prashant-shahi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @campoy and @manishrjain)


worker/mutation.go, line 352 at r1 (raw file):

Previously, campoy (Francesc Campoy) wrote…
"%s"

You should use %q instead, that will add the quotes and escape any special characters.

Done.

@prashant-shahi prashant-shahi merged commit b5d1beb into master Nov 26, 2019
@prashant-shahi prashant-shahi deleted the prashant/error-reformatting branch November 26, 2019 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

Errors are unhelpful

3 participants