Adding more details for mutation error messages with scalar/uid type mismatch#4317
Merged
Conversation
mangalaman93
approved these changes
Nov 25, 2019
campoy
suggested changes
Nov 25, 2019
Contributor
campoy
left a comment
There was a problem hiding this comment.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @manishrjain and @prashant-shahi)
worker/mutation.go, line 352 at r1 (raw file):
"%s"
You should use %q instead, that will add the quotes and escape any special characters.
prashant-shahi
commented
Nov 25, 2019
Contributor
Author
prashant-shahi
left a comment
There was a problem hiding this comment.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @campoy and @manishrjain)
worker/mutation.go, line 352 at r1 (raw file):
Previously, campoy (Francesc Campoy) wrote…
"%s"You should use
%qinstead, that will add the quotes and escape any special characters.
Done.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes dgraph-io/dgraph-js#61
This change is