Skip to content

Docs(Metrics): 21.03 feature documentation for Transaction and Raft metrics#78

Merged
aaroncarey merged 6 commits into
masterfrom
aaroncarey/doc-metrics-D166-D165
Mar 3, 2021
Merged

Docs(Metrics): 21.03 feature documentation for Transaction and Raft metrics#78
aaroncarey merged 6 commits into
masterfrom
aaroncarey/doc-metrics-D166-D165

Conversation

@aaroncarey
Copy link
Copy Markdown
Contributor

@aaroncarey aaroncarey commented Mar 1, 2021

Documentation per dgraph-io/dgraph#7338 (see the "Raft leadership metrics" section) and dgraph-io/dgraph#7339 (see additions to "Health metrics")

Also, this PR reorganizes metric categories (alphabetized, no break-up of existing category contents), updates introduction, corrects headers, adds SEO.

Fixes DOC-166 and DOC-165

Staged here: https://deploy-preview-78--dgraph-docs-repo.netlify.app/deploy/metrics/

@aaroncarey aaroncarey added this to the v21.03 milestone Mar 1, 2021
@aaroncarey aaroncarey marked this pull request as draft March 1, 2021 22:52
@netlify
Copy link
Copy Markdown

netlify Bot commented Mar 1, 2021

Deploy preview for dgraph-docs-repo ready!

Built with commit ab2f17a

https://deploy-preview-78--dgraph-docs-repo.netlify.app

@aaroncarey aaroncarey requested a review from karlmcguire March 1, 2021 23:01
@aaroncarey aaroncarey marked this pull request as ready for review March 1, 2021 23:03
@aaroncarey aaroncarey self-assigned this Mar 1, 2021
Copy link
Copy Markdown
Contributor

@danielmai danielmai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a bunch of suggestions. Otherwise, this looks good.

Comment thread content/deploy/metrics.md Outdated
Comment thread content/deploy/metrics.md Outdated
Comment thread content/deploy/metrics.md Outdated
Comment thread content/deploy/metrics.md Outdated
Comment thread content/deploy/metrics.md Outdated
Co-authored-by: Daniel Mai <daniel@dgraph.io>
Copy link
Copy Markdown
Contributor Author

@aaroncarey aaroncarey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Incorporated reviewer feedback, thanks @danielmai!

Comment thread content/deploy/metrics.md Outdated
Comment thread content/deploy/metrics.md Outdated
Line length, fix period removed by suggested edit.
@aaroncarey aaroncarey merged commit 1034f78 into master Mar 3, 2021
@aaroncarey aaroncarey deleted the aaroncarey/doc-metrics-D166-D165 branch March 3, 2021 00:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants