(release/v1.6) Restore: Account for value size as well (#1358)#1504
Merged
NamanJain8 merged 2 commits intorelease/v1.6from Sep 9, 2020
Merged
(release/v1.6) Restore: Account for value size as well (#1358)#1504NamanJain8 merged 2 commits intorelease/v1.6from
NamanJain8 merged 2 commits intorelease/v1.6from
Conversation
In the existing code, when performing a restore, we didn't consider the size of the value. This means badger would consume a lot of memory if the data consisted of small keys and large values. This PR fixes the issue by forcefully flushing the buffer if it grows beyond 100 MB. (cherry picked from commit b2267c2)
NamanJain8
requested review from
ashish-goswami,
jarifibrahim and
manishrjain
as code owners
NamanJain8
changed the title
jarifibrahim
approved these changes
Sep 9, 2020
Contributor
jarifibrahim
left a comment
jarifibrahim
left a comment
There was a problem hiding this comment.
Reviewable status: 0 of 1 files reviewed, all discussions resolved (waiting on @ashish-goswami, @jarifibrahim, and @manishrjain)
mYmNeo
pushed a commit
to mYmNeo/badger
that referenced
this pull request
Jan 16, 2023
) In the existing code, when performing a restore, we didn't consider the size of the value. This means badger would consume a lot of memory if the data consisted of small keys and large values. This PR fixes the issue by forcefully flushing the buffer if it grows beyond 100 MB. (cherry picked from commit b2267c2) Co-authored-by: Ibrahim Jarif <ibrahim@dgraph.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the existing code, when performing a restore, we didn't consider the size of the
value. This means badger would consume a lot of memory if the data consisted of
small keys and large values. This PR fixes the issue by forcefully flushing the
buffer if it grows beyond 100 MB.
(cherry picked from commit b2267c2)
This change is