Skip to content

Update head while replaying #1372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jarifibrahim merged 9 commits into from
Jun 30, 2020
Merged

Update head while replaying #1372

Changes from 2 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
6e1bd2f
Update head while replaying
Jun 16, 2020
c1afe4b
add asserts
Jun 23, 2020
24b7ccd
fix in-memory mode
Jun 24, 2020
e458e10
fix line length
Jun 24, 2020
b31575d
refactor
Jun 24, 2020
94f0094
refactor
Jun 24, 2020
080af40
fix test
Jun 25, 2020
941632e
more fixes
Jun 25, 2020
b91fb58
Fixup
Jun 29, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions db.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,6 +136,11 @@ func (db *DB) replayFunction() func(Entry, valuePointer) error {
} else {
nv = vp.Encode()
meta = meta | bitValuePointer
// Update vhead. If the crash happens while replay was in progess
// and the head is not updated, we will end up replaying all the
// files again.
y.AssertTrue(!vp.Less(db.vhead))
db.vhead = vp
Comment thread
jarifibrahim marked this conversation as resolved.
Outdated
}

v := y.ValueStruct{
Expand Down Expand Up @@ -998,6 +1003,7 @@ func (db *DB) handleFlushTask(ft flushTask) error {
return nil
}

y.AssertTrue(!ft.vptr.IsZero())
// Store badger head even if vptr is zero, need it for readTs
db.opt.Debugf("Storing value log head: %+v\n", ft.vptr)
db.opt.Debugf("Storing offset: %+v\n", ft.vptr)
Expand Down