chore: update ic-cdk #4286
Merged
chore: update ic-cdk #4286
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viviveevee
commented
Jun 24, 2025
| with_state(|s| { | ||
| s.list_permitted(&Permission::Commit) | ||
| .iter() | ||
| .cloned() |
Contributor
Author
There was a problem hiding this comment.
Suggested change
| .cloned() | |
| .cloned() |
Yes, this is less efficient, but we're talking about a list of max tens of principals. No big deal
Contributor
adamspofford-dfinity
left a comment
adamspofford-dfinity
left a comment
There was a problem hiding this comment.
Where we're not using ManualReply anymore, manual_reply = true must be deleted from the method attribute.
Contributor
Author
|
...duh, thanks for catching that |
adamspofford-dfinity
approved these changes
Jun 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
During #4285 I noticed that
ic-cdkis on a pretty old version. Probably better to bump it...How Has This Been Tested?
e2e should show no functional changes
Checklist: