fix: tsconfig and candid UI encodeStr #419
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hansl
reviewed
Mar 3, 2020
| // "outFile": "./", /* Concatenate and emit output to single file. */ | ||
| // "outDir": "out", /* Redirect output structure to the directory. */ | ||
| // "rootDir": "./", /* Specify the root directory of input files. Use to control the output directory structure with --outDir. */ | ||
| "rootDir": "./", /* Specify the root directory of input files. Use to control the output directory structure with --outDir. */ |
Contributor
There was a problem hiding this comment.
That's actually a bad idea if you don't have a list of files. This will force TypeScript to look into node_modules for example, which we don't want.
Add an include key instead.
hansl
approved these changes
Mar 4, 2020
dfinity-bot
added a commit
that referenced
this pull request
Oct 2, 2020
## Changelog for advisory-db: Branch: master Commits: [rustsec/advisory-db@92e5c88a...ac125ee2](rustsec/advisory-db@92e5c88...ac125ee) * [`f324f2d9`](rustsec/advisory-db@f324f2d) Add advisory for atom crate * [`a1076cfa`](rustsec/advisory-db@a1076cf) Add advisory for out-of-bounds read in array-queue. * [`ee8f6684`](rustsec/advisory-db@ee8f668) Update RUSTSEC-0000-0000.toml * [`d0bdfc95`](rustsec/advisory-db@d0bdfc9) Update RUSTSEC-0000-0000.toml * [`bd394d56`](rustsec/advisory-db@bd394d5) Update RUSTSEC-0000-0000.toml * [`ebd9ffca`](rustsec/advisory-db@ebd9ffc) Update RUSTSEC-0000-0000.toml * [`64d1651e`](rustsec/advisory-db@64d1651) Assigned RUSTSEC-2020-0044 to atom * [`f7c02fae`](rustsec/advisory-db@f7c02fa) add advisory for custom Cell in actix-utils * [`41f95e41`](rustsec/advisory-db@41f95e4) fix url * [`90ac1e0d`](rustsec/advisory-db@90ac1e0) Add advisory for unsound Cell in actix-service * [`0eb24bf2`](rustsec/advisory-db@0eb24bf) Assigned RUSTSEC-2020-0045 to actix-utils * [`9fe2230d`](rustsec/advisory-db@9fe2230) Assigned RUSTSEC-2020-0046 to actix-service * [`6f59b117`](rustsec/advisory-db@6f59b11) Advisory for unsound pinning in actix-http * [`b091551f`](rustsec/advisory-db@b091551) Assigned RUSTSEC-2020-0047 to array-queue * [`09a306db`](rustsec/advisory-db@09a306d) fix date * [`14f4dbb0`](rustsec/advisory-db@14f4dbb) fix date more * [`25c3aaaf`](rustsec/advisory-db@25c3aaa) Assign RUSTSEC-2020-0048 to actix-http * [`17d2fd9b`](rustsec/advisory-db@17d2fd9) fix date for real this time * [`74e85683`](rustsec/advisory-db@74e8568) Advisory for unsound pinning in actix-codec * [`f4faaa9c`](rustsec/advisory-db@f4faaa9) drop comment * [`cc3f69c1`](rustsec/advisory-db@cc3f69c) Assigned RUSTSEC-2020-0049 to actix-codec * [`2522178d`](rustsec/advisory-db@2522178) Add advisory for very old, unsound Actix * [`fe250379`](rustsec/advisory-db@fe25037) Assigned RUSTSEC-2018-0019 to actix-web * [`7f5deb94`](rustsec/advisory-db@7f5deb9) Add misaligned-access soundness issue for dync crate * [`a1f39cc8`](rustsec/advisory-db@a1f39cc) Assigned RUSTSEC-2020-0050 to dync * [`bfa9e126`](rustsec/advisory-db@bfa9e12) Add `rustsec` crate advisory for breaking changes to advisory format ([RustSec/advisory-db#415](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/415)) * [`b136b744`](rustsec/advisory-db@b136b74) Assigned RUSTSEC-2020-0051 to rustsec ([RustSec/advisory-db#416](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/416)) * [`7c95e1b1`](rustsec/advisory-db@7c95e1b) libpnet ([RustSec/advisory-db#335](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/335)) * [`7af85222`](rustsec/advisory-db@7af8522) Assign RUSTSEC-2019-0037 to pnet ([RustSec/advisory-db#418](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/418)) * [`2770460f`](rustsec/advisory-db@2770460) RUSTSEC-2020-0011: rename `obsolete` to `yanked` ([RustSec/advisory-db#419](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/419)) * [`ac125ee2`](rustsec/advisory-db@ac125ee) Translate database into V3 advisory format ([RustSec/advisory-db#420](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/420))
dfinity-bot
added a commit
that referenced
this pull request
May 6, 2021
## Changelog for common: Branch: master Commits: [dfinity-lab/[email protected]](https://github.com/dfinity-lab/common/compare/743936ba8c598d878819171f2c8ff2bd90496b72...49c5837222615d9c587c3032fc70d48483902f25) * [`6e1087e4`](https://github.com/dfinity-lab/common/commit/6e1087e49323704e1d833b36b8010de7b01ddfce) Adding ssh key for Yuhui ([dfinity-lab/common#417](http://r.duckduckgo.com/l/?uddg=https://github.com/dfinity-lab/common/issues/417)) * [`49c58372`](https://github.com/dfinity-lab/common/commit/49c5837222615d9c587c3032fc70d48483902f25) Add ssh key for Leon ([dfinity-lab/common#419](http://r.duckduckgo.com/l/?uddg=https://github.com/dfinity-lab/common/issues/419))
mergify bot
pushed a commit
that referenced
this pull request
May 6, 2021
## Changelog for common: Branch: master Commits: [dfinity-lab/[email protected]](https://github.com/dfinity-lab/common/compare/743936ba8c598d878819171f2c8ff2bd90496b72...49c5837222615d9c587c3032fc70d48483902f25) * [`6e1087e4`](https://github.com/dfinity-lab/common/commit/6e1087e49323704e1d833b36b8010de7b01ddfce) Adding ssh key for Yuhui ([dfinity-lab/common#417](http://r.duckduckgo.com/l/?uddg=https://github.com/dfinity-lab/common/issues/417)) * [`49c58372`](https://github.com/dfinity-lab/common/commit/49c5837222615d9c587c3032fc70d48483902f25) Add ssh key for Leon ([dfinity-lab/common#419](http://r.duckduckgo.com/l/?uddg=https://github.com/dfinity-lab/common/issues/419))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.