fix: display reqwest::Error source #3832
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since reqwest 0.12.1 (seanmonstar/reqwest#2199), fmt::Display for reqwest::Error no longer includes the source. The whole reason for WrappedReqwestError was to avoid displaying the source twice. But since the above change, the source isn't displayed at all. After this change, dfx will once again display the error source(s) for request::Error, but on separate lines ("Caused by:") like other error sources.
ghost
marked this pull request as ready for review
lwshang
approved these changes
Jul 15, 2024
rikonor
pushed a commit
that referenced
this pull request
Feb 3, 2025
Since reqwest 0.12.1 (seanmonstar/reqwest#2199), fmt::Display for reqwest::Error no longer includes the source. The whole reason for WrappedReqwestError was to avoid displaying the source twice. But since the above change, the source isn't displayed at all. After this change, dfx will once again display the error source(s) for request::Error, but on separate lines ("Caused by:") like other error sources.
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Since reqwest 0.12.1 (seanmonstar/reqwest#2199), fmt::Display for reqwest::Error no longer includes the source.
The whole reason for WrappedReqwestError was to avoid displaying the source twice. But since the above change, the source isn't displayed at all.
After this change, dfx will once again display the error source(s) for request::Error, but on separate lines ("Caused by:") like other error sources.
How Has This Been Tested?
Tested locally with
dfx extension installwith an extension.json with missing fieldsBefore
After
Checklist: