Skip to content

chore!: --with-cycles requires --wallet is enforced earlier #3817

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
viviveevee merged 3 commits into from
Jul 3, 2024
Merged

chore!: --with-cycles requires --wallet is enforced earlier #3817

viviveevee merged 3 commits into from
Jul 3, 2024

Conversation

@viviveevee
Copy link
Contributor

@viviveevee viviveevee commented Jul 3, 2024 •
edited
Loading

Description

Internal complaint:

If I pass arguments that won't work, such as --with-cycles without --wallet, it would be nice to get an error about that before walking though the entire interactive wizard.

With this change the user will see the error message instantly. The requirement is not new, just enforced at an earlier point in time.

How Has This Been Tested?

Tested manually

Checklist:

  • The title of this PR complies with Conventional Commits.
  • I have edited the CHANGELOG accordingly.
  • I have made corresponding changes to the documentation.

@viviveevee viviveevee marked this pull request as ready for review July 3, 2024 10:00
@viviveevee viviveevee requested a review from a team as a code owner July 3, 2024 10:00
@viviveevee viviveevee enabled auto-merge (squash) July 3, 2024 10:00
@viviveevee viviveevee merged commit e599de6 into master Jul 3, 2024
@viviveevee viviveevee deleted the severin/explicit-wallet-requirement branch July 3, 2024 14:53
rikonor pushed a commit that referenced this pull request Feb 3, 2025
@viviveevee @rikonor
chore!: --with-cycles requires --wallet is enforced earlier (#3817)
fa79320
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@viviveevee