feat: upload br encoding to asset canister #3791
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
reviewed
Jun 13, 2024
| match (media_type.type_(), media_type.subtype()) { | ||
| (mime::TEXT, _) | (_, mime::JAVASCRIPT) | (_, mime::HTML) => vec![ContentEncoder::Gzip], | ||
| (mime::TEXT, _) | (_, mime::JAVASCRIPT) | (_, mime::HTML) => { | ||
| vec![ContentEncoder::Gzip, ContentEncoder::Brotli] |
There was a problem hiding this comment.
Has this been discussed, as a default behavior, at the product level?
I think it would be better to opt-in, configured in .ic-assets.json
There was a problem hiding this comment.
sns-controlled asset canisters might impossible to sync unless they can opt-in for a subset of files rather than all at once. This is because a proposal's commit by definition has to be a single call.
ghost
approved these changes
Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Asset synchronization now not only uploads
identityandgzipas encodings for MIME typestext,js, andhtml, but alsobrencoding.Fixes SDK-1604
How Has This Been Tested?
Added e2e
Checklist: