fix: --initial-margin for dfx canister delete #3769
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
reviewed
May 24, 2024
ghost
disabled auto-merge
ghost
approved these changes
May 24, 2024
ghost
left a comment
ghost
left a comment
There was a problem hiding this comment.
Just a minor note on the documentation update
Co-authored-by: Eric Swanson <[email protected]>
|
@sesi200
What is the status of the "clean solution"? And what does it consist of? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
dfx canister deleteoccasionally fails because it attempts to withdraw too many cycles from the canister before it is deleted. Usually,dfxtries again with a larger margin of cycles, but sometimes this gets stuck. It is now possible to use--initial-marginto manually supply a margin in case the automatic margin does not work.This is a temporary workaround until a clean solution exists (requires spec change, runtime change, wallet change, agent support).
Fixes SDK-1556
How Has This Been Tested?
Tested manually on mainnet
Checklist: