feat: add support for dfx canister url <CANISTER>
#3765
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rl` methods into a separate module under `dfx/src/util` folder.
lwshang
reviewed
May 29, 2024
lwshang
requested changes
May 29, 2024
Contributor
lwshang
left a comment
lwshang
left a comment
There was a problem hiding this comment.
Just a few items:
- Show URL for remote canisters
CHANGELOG.mddocs/cli-reference/dfx-canister.mdx
lwshang
approved these changes
Jun 11, 2024
rikonor
pushed a commit
that referenced
this pull request
Feb 3, 2025
* Get the principal id of the input canister. * Print the URLs for both asset canisters and none-asset canisters. * Handle the remote canisters, also run the formatter. * Keep the output format consistent with `dfx deploy`. * Move the shared `construct_frontend_url` and `construct_ui_canister_url` methods into a separate module under `dfx/src/util` folder. * Add e2e tests for `dfx canister url` command. * Fixed shellcheck. * Fixed Lint builds. * Remove the remote restriction, and add a test for the remote canister. * Add changelog and document. --------- Co-authored-by: Linwei Shang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add a command for dfx:
dfx canister url <CANISTER>that gives the URL for a canister.Fixes SDK-1613
How Has This Been Tested?
e2e/tests-dfx/canister_url.bash.Checklist: