fix: Capitalization of "Wasm" #3756
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This replace incorrect capitalization of "WASM" with "Wasm", which is the official abbreviation of WebAssembly. See: https://webassembly.org/ The reason why not all letters are capitalized is because "Wasm" is not an acronym, but rather an abbreviation. This change also fixes capitalization of the canister status output to be consistent wih other fields.
ghost
approved these changes
May 14, 2024
Contributor
Author
|
@ericswanson-dfinity: thanks for the fast review! To double check: is it safe to change the user facing messages this way? I was wondering it that could break some scripts. |
It's always possible that changing the output of a program could break some scripts. I suppose you could call out the change to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces incorrect capitalization of "WASM" with "Wasm", which is the official abbreviation of WebAssembly.
See: https://webassembly.org/
The reason why not all letters are capitalized is because "Wasm" is not an acronym, but rather an abbreviation.
This change also fixes capitalization of the canister status output to be consistent wih other fields.