Skip to content

Conversation

@ghost
Copy link

@ghost ghost commented May 8, 2024

Description

Renames (with deprecation0 two methods, since the criterion involved is whether the network is mainnet or not, rather than whether it is the local network or not, and the "local" setting also applies to testnets.

  • fetch_root_key_when_local -> fetch_root_key_when_non_mainnet
  • fetch_root_key_when_local_or_error -> fetch_root_key_when_non_mainnet_or_error

The motivation is an upcoming improvement to the interface used at https://github.com/dfinity/dfx-extensions/blob/main/extensions/nns/src/commands/install.rs#L70

How Has This Been Tested?

Refactor covered by CI

Checklist:

  • The title of this PR complies with Conventional Commits.
  • I have edited the CHANGELOG accordingly.
  • I have made corresponding changes to the documentation.

@ghost ghost requested review from a team and chenyan-dfinity as code owners May 8, 2024 17:54
@ghost ghost enabled auto-merge (squash) May 8, 2024 18:32
@ghost ghost merged commit a089dab into master May 8, 2024
@ghost ghost deleted the ens/fetch-root-key-method-names branch May 8, 2024 20:13
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant