fix: removed version switching logic #3624
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
force-pushed
the
ens/remove-version-switching
branch
from
3f632d1 to
9d6ed2f
Compare
ghost
marked this pull request as ready for review
lwshang
approved these changes
Mar 12, 2024
ghost
enabled auto-merge (squash)
ghost
mentioned this pull request
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove the version checking/switching logic (DFX_VERSION, "dfx" field in dfx.json) because dfxvm handles this now.
Fixes https://dfinity.atlassian.net/browse/SDK-1458
How Has This Been Tested?
Tested locally that it ignores DFX_VERSION and the dfx field in dfx.json
Checklist: