Add a jobset for doing SDK releases #164
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
basvandijk
force-pushed
the
basvandijk/sdk-release
branch
from
7f01c39 to
9fe7083
Compare
basvandijk
force-pushed
the
basvandijk/sdk-release
branch
2 times, most recently
from
256d6bc to
caf512f
Compare
eftychis
reviewed
Nov 12, 2019
ci/release.nix is called by the sdk-release jobset on hydra. It calls release-jobset.nix which returns the dfx-release and install-sh-release derivations but only when the git revision has been tagged with a release tag (v0.1.2). In that case the version in those derivations is set to the version in the tag ensuring that they get rebuild.
basvandijk
force-pushed
the
basvandijk/sdk-release
branch
from
caf512f to
209e5a2
Compare
paulyoung
pushed a commit
that referenced
this pull request
Nov 15, 2019
ci/release.nix is called by the sdk-release jobset on hydra. It calls release-jobset.nix which returns the dfx-release and install-sh-release derivations but only when the git revision has been tagged with a release tag (v0.1.2). In that case the version in those derivations is set to the version in the tag ensuring that they get rebuild.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preliminary idea on how to do SDK releases. To be discussed tomorrow.
ci/release.nixis called by thesdk-releasejobset on hydra. It callsrelease-jobset.nixwhich returns thedfx-releaseandinstall-sh-releasederivations but only when the git revision has beentagged with a release tag (
v0.1.2). In that case the version in thosederivations is set to the version in the tag ensuring that they get
rebuild.
This depends on:
https://github.com/dfinity-lab/hydra-jobsets/pull/26
https://github.com/dfinity-lab/common/pull/61