Skip to content

Conversation

@ilbertt
Copy link
Member

@ilbertt ilbertt commented Dec 17, 2025

Description

We should do sync time after seeing an invalid ingress expiry error for read_state requests.

How Has This Been Tested?

Added test case that uses the mock replica.

Checklist:

  • My changes follow the guidelines in CONTRIBUTING.md.
  • The title of this PR complies with Conventional Commits.
  • I have edited the CHANGELOG accordingly.
  • I have made corresponding changes to the documentation.

@ilbertt ilbertt requested a review from a team as a code owner December 17, 2025 17:05
@github-actions
Copy link
Contributor

github-actions bot commented Dec 17, 2025

size-limit report 📦

Path Size
@icp-sdk/core 91 B (0%)
@icp-sdk/core/agent 51.03 KB (-0.02% 🔽)
@icp-sdk/core/candid 13.31 KB (0%)
@icp-sdk/core/identity 20.49 KB (0%)
@icp-sdk/core/identity/secp256k1 33.81 KB (0%)
@icp-sdk/core/principal 4.44 KB (0%)

@ilbertt ilbertt requested a review from mraszyk December 17, 2025 17:09
Copy link
Contributor

@mraszyk mraszyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but haven't reviewed the tests.

@ilbertt ilbertt requested a review from lwshang December 17, 2025 17:26
Copy link
Contributor

@mraszyk mraszyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still LGTM

@ilbertt ilbertt merged commit 23ba3f6 into main Dec 17, 2025
26 checks passed
@ilbertt ilbertt deleted the luca/sync-time-read-state branch December 17, 2025 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants