Skip to content

Conversation

@ilbertt
Copy link
Member

@ilbertt ilbertt commented Dec 3, 2025

Description

Supports both subnet id and canister id for certificate verification. The CreateCertificateOptions.canisterId field has been replaced with the principal field, of type:

type CertificatePrincipal =
  | {
      canisterId: Principal;
    }
  | {
      subnetId: Principal;
    };

How Has This Been Tested?

Same tests should still pass.

Checklist:

  • My changes follow the guidelines in CONTRIBUTING.md.
  • The title of this PR complies with Conventional Commits.
  • I have edited the CHANGELOG accordingly.
  • I have made corresponding changes to the documentation.

@ilbertt ilbertt requested a review from a team as a code owner December 3, 2025 12:56
@github-actions
Copy link
Contributor

github-actions bot commented Dec 3, 2025

size-limit report 📦

Path Size
@icp-sdk/core 91 B (0%)
@icp-sdk/core/agent 50.68 KB (+0.1% 🔺)
@icp-sdk/core/candid 13.31 KB (0%)
@icp-sdk/core/identity 20.55 KB (0%)
@icp-sdk/core/identity/secp256k1 33.75 KB (0%)
@icp-sdk/core/principal 4.44 KB (0%)

@ilbertt ilbertt marked this pull request as draft December 3, 2025 13:51
@ilbertt ilbertt marked this pull request as ready for review December 3, 2025 14:46
@ilbertt ilbertt merged commit 8975b9d into main Dec 3, 2025
27 checks passed
@ilbertt ilbertt deleted the luca/certificate-subnet branch December 3, 2025 14:47
ilbertt added a commit that referenced this pull request Dec 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants