Skip to content

refactor(agent): split read state into inner function #1231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ilbertt merged 2 commits into from
Dec 2, 2025
Merged

refactor(agent): split read state into inner function #1231

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8b89fd0
refactor: split read state into inner function
ilbertt Dec 2, 2025
36c73dd
refactor: remove unneeded request id calculation
ilbertt Dec 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 8 additions & 5 deletions packages/core/src/agent/agent/http/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1106,7 +1106,6 @@ export class HttpAgent implements Agent {
if (request) {
// This is a pre-signed request
transformedRequest = request;
requestId = requestIdOf(transformedRequest);
} else {
// This is fields, we need to create a request
requestId = getRequestId(fields);
Expand All @@ -1121,8 +1120,14 @@ export class HttpAgent implements Agent {

const url = new URL(`/api/v2/canister/${canister.toString()}/read_state`, this.host);

this.log.print(`fetching "${url.pathname}" with request:`, transformedRequest);
return await this.#readStateInner(url, transformedRequest, requestId);
}

async #readStateInner(
url: URL,
transformedRequest: ReadStateRequest,
requestId?: RequestId,
): Promise<ReadStateResponse> {
const backoff = this.#backoffStrategy();
try {
const { responseBodyBytes } = await this.#requestAndRetry({
Expand All @@ -1138,15 +1143,13 @@ export class HttpAgent implements Agent {

const decodedResponse: ReadStateResponse = cbor.decode(responseBodyBytes);

this.log.print('Read state response:', decodedResponse);

return decodedResponse;
} catch (error) {
let readStateError: AgentError;
if (error instanceof AgentError) {
// override the error code to include the request details
error.code.requestContext = {
requestId,
requestId: requestId ?? requestIdOf(transformedRequest),
senderPubKey: transformedRequest.body.sender_pubkey,
senderSignature: transformedRequest.body.sender_sig,
ingressExpiry: transformedRequest.body.content.ingress_expiry,
Expand Down
Loading