feat(agent): getCanisterEnv and safeGetCanisterEnv (experimental)
#1156
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
size-limit report 📦
|
4 tasks
ilbertt
changed the title
getCanisterEnv and safeGetCanisterEnvgetCanisterEnv and safeGetCanisterEnv
viviveevee
reviewed
Oct 6, 2025
viviveevee
approved these changes
Oct 7, 2025
This was referenced Oct 7, 2025
ilbertt
added a commit
to dfinity/icp-cli
that referenced
this pull request
Oct 9, 2025
dfinity/sdk#4387 enables asset canisters to serve the canister environment variables prefixed with `PUBLIC_` in the `ic_env` cookie. Additionally, switches the frontend-environment-variables asset canister to the one hosted on GitHub, which supports the `ic_env` cookie. Additionally, aligns the doc comments to the latest pushes on dfinity/icp-js-core#1156.
ilbertt
commented
Oct 21, 2025
viviveevee
approved these changes
Oct 21, 2025
ilbertt
changed the title
getCanisterEnv and safeGetCanisterEnvgetCanisterEnv and safeGetCanisterEnv (experimental)
viviveevee
approved these changes
Oct 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Introduces the
getCanisterEnvandsafeGetCanisterEnvfunctions to load the canister environment from theic_envcookie. This is an experimental feature.Additionally, adds the
@types/jsdompackage to the dev dependencies to avoid typescript errors.Related: dfinity/sdk#4387.
How Has This Been Tested?
Introduced ad-hoc unit tests.
Checklist: