feat(subnet): allow --id with node list when they match #1700
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### Motivation - Allow passing a subnet id together with node lists when replacing, provided they belong to that subnet. ### Solution - Accept --id/--subnet-id alongside --remove-nodes/--add-nodes and validate against registry; add validate_subnet_id_and_nodes(). ### Details - Rename fields: remove_nodes, subnet_id, add_count/remove_count; derive SubnetTarget from remove_nodes when id omitted. ### Details - Use SubnetQueryBy::NodeList to resolve subnet and error on mismatch. ### Meta - updated tests accordingly
NikolaMilosa
approved these changes
Sep 1, 2025
DFINITYManu
approved these changes
Sep 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Solution
Details
Meta — updated tests accordingly