Skip to content

feat(node-provider-rewards): Perform inter-canister calls using non-blocking calls #1531

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
pietrodimarco-dfinity merged 7 commits into from
May 7, 2025
Merged

feat(node-provider-rewards): Perform inter-canister calls using non-blocking calls #1531

pietrodimarco-dfinity merged 7 commits into from
May 7, 2025

Conversation

@pietrodimarco-dfinity
Copy link
Contributor

@pietrodimarco-dfinity pietrodimarco-dfinity commented May 7, 2025

Changes:

  • Bump ic-cdk dep to 0.18 (where bounded calls are supported)
  • Adapt metrics fetching to use bounded calls
  • Adapt tests
  • Introducing RegistryClient to query registry using bounded calls

TODO:

  • Remove RegistryClient once RegistryClient in IC repo depends on ic-cdk 0.18

@pietrodimarco-dfinity pietrodimarco-dfinity requested a review from a team as a code owner May 7, 2025 06:00
@NikolaMilosa NikolaMilosa mentioned this pull request May 7, 2025
Closed
@DFINITYManu DFINITYManu requested a review from NikolaMilosa May 7, 2025 10:43
@pietrodimarco-dfinity pietrodimarco-dfinity merged commit c657b38 into main May 7, 2025
9 checks passed
@pietrodimarco-dfinity pietrodimarco-dfinity deleted the pmarco/use-bounded-calls-for-sync branch May 7, 2025 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@NikolaMilosa NikolaMilosa Awaiting requested review from NikolaMilosa

1 more reviewer

@DFINITYManu DFINITYManu DFINITYManu approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@pietrodimarco-dfinity @NikolaMilosa @DFINITYManu