Refactoring node provider rewards canister #1467
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Removed FR types - Computing failure rates directly with NodeMetricsDailyProcessed
DFINITYManu
reviewed
Apr 14, 2025
rs/dre-canisters/node-provider-rewards/canister/api/src/endpoints.rs
Outdated
Show resolved
Hide resolved
DFINITYManu
reviewed
Apr 14, 2025
rs/dre-canisters/node-provider-rewards/canister/api/src/endpoints.rs
Outdated
Show resolved
Hide resolved
DFINITYManu
approved these changes
Apr 14, 2025
Contributor
|
MSD Diff No diff |
pietrodimarco-dfinity
deleted the
pmarco/refactoring-node-provider-rewards
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
serde_cborHashMap<SubnetMetricsDailyKey, Vec<NodeMetricsDaily>>as input for constructing Rewards Calculatorget_node_providers_rewards_xdr_totalandget_node_provider_rewards_calculationnow executed with < 1.5bln instruction for 2 months periodTODO: