fix(cli): improve version upgrade checks #1407
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### Major Changes - **Method `run`:** Augmented with an additional parameter `curr_version` to decouple version retrieval from method logic. - **Signature Update:** The `check` and `check_latest_release` methods now utilize a string reference for `curr_version`, improving interface consistency. - **Logging Enhancement:** Added version comparison logging for enhanced traceability using `info!` macro. - **Version Pattern Matching:** Extended regular expression for version format consistency. ### Tests - Updated tests to align with interface changes.
sasa-tomic
changed the title
NikolaMilosa
approved these changes
Mar 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Major Changes
Refactor
UpgradeCommand: Pass the current version (curr_version) as an explicit argument toUpgrade::runandUpgrade::checkmethods instead of using environment constants, for improved robustness.Update Regex for Version Parsing: Modified the regular expression in
check_latest_releaseto accommodate version strings with-vprefixes, improving version specification accuracy and compatibility with git tags we use.Log Enhancements: Added logging to display the current and latest release versions during checks, increasing visibility for users.
In particular, previous code was always trying to upgrade when running from bazel due to special env variable handling, and it also wasn't able to handle versions like
0.6.0-v0.6.1that would sometimes show up locally.