feat: Add Prometheus telemetry to node provider rewards canister. #1389
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds very basic support for Prometheus telemetry (including a mechanism to encode metrics using the `ic-metrics-encoder` crate). The metrics added are: * Generic memory usage coming from IC NNS metrics code. * Metrics calculation start, success and end timestamps.
… to Dimitris Sarlis for this keen observation.
sasa-tomic
reviewed
Mar 19, 2025
sasa-tomic
approved these changes
Mar 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds very basic support for Prometheus telemetry (including a mechanism to encode metrics using the
ic-metrics-encodercrate).The metrics added are: