feat(cli): support forum post link simulation #1364
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### Additions - Introduced `forum_post_link_for_simulation` method to `ForumParameters` for handling forum post link. - Extended `simulate` methods across multiple executors to accept `forum_post_link_description`. ### Updates - Modified `simulate_proposal` function signature to include `forum_post_link_description`. - Adjusted simulator functions to log the forum post link when running simulations. ### Testing - Updated unit tests to handle additional `forum_post_link_description` parameter.
LittleChimera
approved these changes
Mar 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Primary Changes
Forum Post Link Simulation:
forum_post_link_for_simulationmethod toForumParametersto generate a link for simulation purposes.simulatefunction implementations inGovernanceCanisterProposalExecutor,ProposalExecutionViaGovernanceCanister, andIcAdmintraits to include an optional forum post link description when simulating proposals.Unit Tests: