refactor: encapsulate NodeOperator computed fields #1256
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Introduced `NodeOperatorComputed` struct to encapsulate computed fields from `NodeOperator`. - Updated `node_allowance_remaining`, `node_allowance_total`, `total_up_nodes`, `nodes_health`, `rewards_correct`, `nodes_in_subnets`, and `nodes_in_registry` to be encapsulated within `NodeOperatorComputed`. - Replaced direct accesses to `NodeOperator` fields with accesses to the corresponding fields in `NodeOperatorComputed`. - Modified existing code to reflect this encapsulation, enhancing code organization and clarity. - Updated tests accordingly to accommodate the new structure. - Replaced `allowance` with `node_allowance` across various components for naming consistency.
NikolaMilosa
approved these changes
Jan 29, 2025
pietrodimarco-dfinity
approved these changes
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Introduced
NodeOperatorComputedstruct to group computed fields withinNodeOperator.Updated fields under the
computedstruct:nodes_health,total_up_nodes,rewards_correct,node_allowance_remaining,node_allowance_total,nodes_in_subnets, andnodes_in_registry.Renamed
allowancetonode_allowanceconsistently across the codebase.Updated logic in
Registryfor better encapsulation of computed properties, including calculation ofnode_allowance_totaland condition checks involvingtotal_up_nodes.Updated tests and affected modules to reflect struct and field changes.