Skip to content

fix: Only consider available nodes for network operator assignment #1067

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sasa-tomic merged 2 commits into from
Nov 11, 2024
Merged

fix: Only consider available nodes for network operator assignment #1067

sasa-tomic merged 2 commits into from
Nov 11, 2024

Conversation

@sasa-tomic
Copy link
Collaborator

@sasa-tomic sasa-tomic commented Nov 11, 2024 •
edited
Loading

  • Refactor the code to ensure only available nodes are considered for network operator assignments.
  • Variable renaming for better understanding.

@sasa-tomic
fix(dre): Only consider available nodes for network --ensure-operator…
7644b07 
…-nodes-assigned

Plus some minor refactoring to clarify which data variables hold
@sasa-tomic sasa-tomic requested a review from a team as a code owner November 11, 2024 10:49
@sasa-tomic sasa-tomic changed the title Only consider available nodes for network operator assignment fix: Only consider available nodes for network operator assignment Nov 11, 2024
pietrodimarco-dfinity
pietrodimarco-dfinity approved these changes Nov 11, 2024
View reviewed changes
Copy link
Contributor

@pietrodimarco-dfinity pietrodimarco-dfinity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ;)

@sasa-tomic sasa-tomic merged commit c9d7f33 into main Nov 11, 2024
4 checks passed
@sasa-tomic sasa-tomic deleted the sat-node-operator-only-available branch November 11, 2024 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pietrodimarco-dfinity pietrodimarco-dfinity pietrodimarco-dfinity approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sasa-tomic @pietrodimarco-dfinity