Merged
Conversation
* chore: Fix interop test certs * fix bash script:
* fix: tls config overwrite in endpoint PR hyperium#1866 fixed the breaking change introduced in hyperium#1731, but resets the TLS config without checking if `tls` is set. This patch resolves the regression and restores expected behaviour. * fix: cargo fmt whitespace check --------- Co-authored-by: vigneshwar.sm <vigneshwar.sm@zohocorp.com> Co-authored-by: Lucio Franco <luciofranco14@gmail.com>
Co-authored-by: Lucio Franco <luciofranco14@gmail.com>
Created using spr 1.3.6-beta.1
Reviewers: Pull Request: hyperium#2266
* chore: box Status contents (hyperium#2253) * chore: use private into_status method
* fix outdated limit in comment This mention was missed when the default changed in hyperium#1335 * Add backquotes Co-authored-by: tottoto <tottotodev@gmail.com> --------- Co-authored-by: tottoto <tottotodev@gmail.com>
…2291) Co-authored-by: Lucio Franco <luciofranco14@gmail.com> Co-authored-by: tottoto <tottotodev@gmail.com>
…m#2299) * Allow setting TCP_KEEPINTVL and TCP_KEEPCNT * fix windows * fix clippy windows
The boxed `Decoder` inside `Streaming` need not be `Sync` since hyperium#804. Unfortunately, that makes `Streaming` non-`Sync`, meaning that all the generated `tonic` futures cannot be awaited in `Sync` futures. In fact, the only times we use the `Decoder`, we have a `&mut` unique reference to it, so we are guaranteed not to require synchronization. The `sync_wrapper` crate encodes this reasoning, allowing us to safely make the `Streaming` type `Sync` regardless of whether the contained `Decoder` is `Sync` or not.
Co-authored-by: Lucio Franco <luciofranco14@gmail.com>
Co-authored-by: tottoto <tottotodev@gmail.com>
…yperium#2308) * doc: try to improve the doc-disparity between `tonic-build`'s `lib.rs` and the readme * Fix indentation * fix the doctests * fix a typo and retes an assumption * Change `compile_fail` to `ignore` Co-authored-by: tottoto <tottotodev@gmail.com> --------- Co-authored-by: tottoto <tottotodev@gmail.com>
Co-authored-by: Arjan Singh Bal <46515553+arjan-bal@users.noreply.github.com> Co-authored-by: Easwar Swaminathan <easwars@google.com>
Collaborator
|
I see that the external-types test is failing because of the code I added to test the tonic transport in |
arjan-bal
approved these changes
Jul 11, 2025
Owner
Author
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
17 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.