React strict mode errors #1037
Open
React strict mode errors #1037
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 24, 2025 17:25
…hey are not valid attributes, a disabled child, naming issues
mere-z
added
🐞 bug 🐛
added 8 commits
July 24, 2025 18:42
…ion so we dont get weird , 2025 options that never get rendered
…coders call usecontext once and pass it down
…ods instead of the old routes, route way, added future flag toggles
…rs only when u start typing in course sel
mark-trann
reviewed
Aug 27, 2025
| @@ -23,34 +22,49 @@ Sentry.init({ | |||
| tracesSampleRate: Number(import.meta.env.VITE_APP_SENTRY_TRACE_RATE_CLIENT), | |||
| }); | |||
|
|
|||
| const Root: React.FC = () => { | |||
| const hasVisited = localStorage.getItem('visited'); | |||
| const hasVisited = localStorage.getItem('visited'); | |||
| </ApolloProvider> | ||
| ); | ||
| }; | ||
| const router = createBrowserRouter( |
| @@ -402,6 +402,25 @@ const CourseSelect: React.FC<CourseSelectProps> = ({ assignedColors, handleSelec | |||
| const isMedium = useMediaQuery(theme.breakpoints.only('md')); | |||
| const isTiny = useMediaQuery(theme.breakpoints.only('xs')); | |||
|
|
|||
| // Each time we select a course, add that course to options | |||
| // (removes MUI warning about course selected not being in options) | |||
| const mergedOptions = React.useMemo(() => { | |||
There was a problem hiding this comment.
nitpick:
const mergedOptions = useMemo(() => {
|
|
||
| const decodedColors = colors.map((color) => { | ||
| const decodedColor = useColorDecoder(color); | ||
| const decodedColor = useColorDecoder(color, currentTheme); |
There was a problem hiding this comment.
the second argument was optional. What was the error that needed this change?
Comment on lines
+447
to
+448
| const { key, ...rest } = props; | ||
| return ( |
There was a problem hiding this comment.
was the issue here with the key not being assigned correctly?
Comment on lines
+108
to
+128
| <FormControl > | ||
| <StyledInputLabel id="select-term-label">Select term</StyledInputLabel> | ||
| <CustomStyledSelect | ||
| size="small" | ||
| labelId="select-term-label" | ||
| id="select-term" | ||
| label="Select term" | ||
| open={open} | ||
| onClose={handleClose} | ||
| onOpen={handleOpen} | ||
| value={termName != '' ? termName.concat(', ', term?.substring(2)) as string : ''} | ||
| onChange={selectTerm} | ||
| > | ||
| {Array.from(termDataStrList).map((term, index) => { | ||
| return ( | ||
| <MenuItem key={index} value={term}> | ||
| {term} | ||
| </MenuItem> | ||
| ); | ||
| })} | ||
| </CustomStyledSelect> |
| @@ -32,13 +34,14 @@ interface ColorThemePreviewProps { | |||
| export const ColorThemePreview = ({ previewTheme }: ColorThemePreviewProps) => { | |||
| const decodedColors = Object.fromEntries( | |||
| Object.entries(colors).map(([key, color]) => { | |||
| const decodedColor = useColorDecoder(color, previewTheme); | |||
| const { currentTheme } = useContext(AppContext); | |||
There was a problem hiding this comment.
move this outside the map
| @@ -33,15 +33,15 @@ const drawerWidth = 230; | |||
| interface StyledDrawerProps { | |||
| collapsed: boolean; | |||
| isMobile: boolean; | |||
| collapsedWidth: number; | |||
| collapsedwidth: number; | |||
There was a problem hiding this comment.
variable name convention is camelCase
| @@ -49,9 +49,9 @@ const TimetableTabs: React.FC = () => { | |||
|
|
|||
| const addTimetabletip = isMacOS ? 'New Tab (Cmd+Enter)' : 'New Tab (Ctrl+Enter)'; | |||
|
|
|||
| const [tabTheme, setTabTheme] = useState<TabTheme>(isDarkMode ? tabThemeDark : tabThemeLight); | |||
| const [tabtheme, setTabTheme] = useState<TabTheme>(isDarkMode ? tabThemeDark : tabThemeLight); | |||
Comment on lines
+45
to
+47
| future: { | ||
| v7_relativeSplatPath: true, | ||
| }, |
There was a problem hiding this comment.
this helps with future migration to v7 which is good. Curious what prompted you to add this in?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 🧾
Context of PR, summary of changes, as well as any relevant technical decisions/motivations.
Testing
Replace this line with instructions on how to test your changes, as well as any relevant images for UI changes.
Checklist
feature: for application feature improvement or new featuresbug: fixing something that previously wasn't workingdev: development-side related changesdocker: updates to the Docker codesetup: changes to the setup/infrastructure of the codebasetest: updates to internal testing