Timetable routes #1023
Closed
Timetable routes #1023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lhvy
requested changes
Jul 10, 2025
server/src/user/user.controller.ts
Outdated
| Number(year), | ||
| term, | ||
| ); | ||
| return; |
There was a problem hiding this comment.
No need to write return if the function just ends with no return value.
server/src/user/user.service.ts
Outdated
| }); | ||
|
|
||
| if (!timetable) { | ||
| throw new ForbiddenException('Timetable does not belong to this user.'); |
There was a problem hiding this comment.
Can we make all instances of no timetable for userId + timetableId a 404 instead.
added 2 commits
July 24, 2025 16:32
sunnyyuqingchen
force-pushed
the
timetable-routes
branch
from
c3d441d to
50c8dc0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added routes for:
GET /user/timetables
GET /user/timetables/:id/view
POST /user/timetables
PATCH /user/timetables/:id/change-primary
DELETE /user/timetables/:id