Skip to content

Optimize retrieval and propagation of X-Sha #124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 18, 2024
Merged

Optimize retrieval and propagation of X-Sha #124

merged 1 commit into from
Oct 18, 2024

Conversation

kzu
Copy link
Member

@kzu kzu commented Oct 18, 2024

Simplify retrieval by leveraging JQ support in GH CLI, and always ensure we propagate the latest value for the X-Sha header.

@kzu kzu added the enhancement New feature or request label Oct 18, 2024
@kzu kzu enabled auto-merge (rebase) October 18, 2024 20:53
@devlooped-bot
Copy link
Member

devlooped-bot commented Oct 18, 2024

20 passed 20 passed

🧪 Details on Microsoft Windows 10.0.20348

✅ Devlooped.FileSpecTests.CalculateDefaultPath(url: "https://github.com/devlooped/dotnet-file/blob/main"···, path: "src/Directory.props")
✅ Devlooped.FileSpecTests.CalculateDefaultPath(url: "https://github.com/devlooped/dotnet-file/raw/main/"···, path: "src/Directory.props")
✅ Devlooped.FileSpecTests.CalculateDefaultPath(url: "https://github.com/devlooped/dotnet-file/tree/main"···, path: "src/")
✅ Devlooped.FileSpecTests.CalculateDefaultPath(url: "https://raw.githubusercontent.com/kzu/dotnet-file/"···, path: "docs/img/icon.png")
✅ Devlooped.FileSpecTests.CalculateDefaultPath(url: "https://raw.githubusercontent.com/kzu/dotnet-file/"···, path: "README.md")
✅ Devlooped.FileSpecTests.WhenPathHasDot(url: "https://github.com/devlooped/dotnet-file/blob/main"···, path: ".", expected: "Foo.cs")
✅ Devlooped.FileSpecTests.WhenPathHasDot(url: "https://github.com/devlooped/dotnet-file/blob/main"···, path: "src/External/.", expected: "src/External/Foo.cs")
✅ Devlooped.FileSpecTests.WhenPathHasDot(url: "https://github.com/devlooped/dotnet-file/tree/main"···, path: "src/External/.", expected: "src/External/.")
✅ Devlooped.FileSpecTests.WhenPathIsDirAppendsDefaultPath(url: "https://github.com/devlooped/dotnet-file/blob/main"···, path: "./", expected: ".editorconfig")
✅ Devlooped.FileSpecTests.WhenPathIsDirAppendsDefaultPath(url: "https://github.com/devlooped/dotnet-file/blob/main"···, path: "./src/", expected: "src/.editorconfig")
✅ Devlooped.FileSpecTests.WhenPathIsDirAppendsDefaultPath(url: "https://github.com/devlooped/dotnet-file/blob/main"···, path: "docs/", expected: "docs/src/Directory.props")
✅ Devlooped.FileSpecTests.WhenPathIsDirAppendsDefaultPath(url: "https://github.com/devlooped/dotnet-file/raw/main/"···, path: "./", expected: "src/Directory.props")
✅ Devlooped.FileSpecTests.WhenPathIsDirAppendsDefaultPath(url: "https://github.com/devlooped/dotnet-file/raw/main/"···, path: "external/docs/", expected: "external/docs/src/Directory.props")
✅ Devlooped.FileSpecTests.WhenPathIsDirAppendsDefaultPath(url: "https://github.com/devlooped/dotnet-file/tree/main"···, path: "./common/", expected: "common/src/docs")
✅ Devlooped.FileSpecTests.WhenPathIsDirAppendsDefaultPath(url: "https://github.com/devlooped/dotnet-file/tree/main"···, path: "external/", expected: "external/src")
✅ Devlooped.FileSpecTests.WhenPathIsDirAppendsDefaultPath(url: "https://raw.githubusercontent.com/kzu/dotnet-file/"···, path: "./external/", expected: "external/docs/img/icon.png")
✅ Devlooped.FileSpecTests.WhenPathIsDirAppendsDefaultPath(url: "https://raw.githubusercontent.com/kzu/dotnet-file/"···, path: "docs/src/", expected: "docs/src/README.md")
✅ Devlooped.FileSpecTests.WhenPathIsDirAppendsDefaultPath(url: "https://raw.githubusercontent.com/kzu/dotnet-file/"···, path: "external/", expected: "external/docs/img/icon.png")
✅ Devlooped.FileSpecTests.WhenPathIsFinalDoesNotReplaceDot
✅ Devlooped.FileSpecTests.WhenSourceUriEndsInSlathThenTargetPathIsBaseDir

from dotnet-retest v0.6.3 on .NET 8.0.8 with 💜

Simplify retrieval by leveraging JQ support in GH CLI, and always ensure we propagate the latest value for the X-Sha header.
@kzu kzu merged commit 9814380 into main Oct 18, 2024
11 checks passed
@kzu kzu deleted the dev/xsha branch October 18, 2024 20:56
@devlooped devlooped locked and limited conversation to collaborators Nov 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants