Skip to content

Conversation

@sghng
Copy link

@sghng sghng commented Sep 27, 2025

Double check these details before you open a PR

  • PR does not match another non-stale PR currently opened
  • PR name matches the format new icon: Icon name (versions separated by comma). More details here
  • PR's base is the develop branch.
  • Your icons are inside a folder as seen here
  • SVG matches the standards laid out here
  • A new object is added in the devicon.json file at the correct alphabetic position as seen here

This PR closes NONE

Link to prove your SVG is correct and up-to-date.

Icons got from Starship repository: https://github.com/starship/starship/tree/master/media

@sghng sghng marked this pull request as draft October 7, 2025 18:43
@sghng sghng marked this pull request as ready for review October 9, 2025 23:47
@sghng sghng changed the title new icon: starship (original, original-wordmark) new icon: starship (original, original-wordmark, plain) Oct 9, 2025
Copy link
Contributor

@weh weh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @sghng, thank you for your contribution. Nice work, but there are two things to change. The original-wordmark version needs to be optimized (e.g. with svgomg.net).

Also it would be nice if you could create a single color version plain-wordmark, like the plain icon.

Copilot AI review requested due to automatic review settings December 5, 2025 15:55
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds a new Starship icon to the devicon collection. Starship is a cross-shell prompt customization tool, and the icons are sourced from the official Starship repository.

Key Changes:

  • Added three SVG variants: original, plain, and original-wordmark
  • Updated devicon.json with the new starship entry

Reviewed changes

Copilot reviewed 1 out of 4 changed files in this pull request and generated 1 comment.

File Description
icons/starship/starship-original.svg Original colored SVG with gradient (purple to pink) depicting the Starship rocket logo
icons/starship/starship-plain.svg Plain monochrome version using the brand color #dd0b78
icons/starship/starship-original-wordmark.svg Original version with "Starship" wordmark and "CROSS-SHELL PROMPT" tagline
devicon.json Added starship entry in correct alphabetical position with tags for shell, terminal, and tool

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@sghng sghng requested a review from weh December 5, 2025 17:01
@sghng
Copy link
Author

sghng commented Dec 5, 2025

plain-wordmark has been created!

Copy link
Contributor

@weh weh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i merged the three paths into a single one in the plain wordmark version.

@weh weh added feature:icon PR when a new icon is ready to be added to the collection bot:peek Trigger peek-bot. Remove and re-add the label to re-trigger bot:check Trigger check-bot. Remove and re-add the label to re-trigger labels Dec 9, 2025
@weh weh requested review from a team, Snailedlt, canaleal and lunatic-fox and removed request for a team December 9, 2025 16:42
@github-actions
Copy link
Contributor

github-actions bot commented Dec 9, 2025

Hi there,

I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io.

Here are the SVGs as intepreted by Icomoon when we upload the files:
Imgur Images

Here are the zoomed-in screenshots of the added icons as SVGs:
Imgur Images Imgur Images

Here are the icons that will be generated by Icomoon:
Imgur Images

Here are the zoomed-in screenshots of the added icons as icons:
Imgur Images Imgur Images

Here are the colored versions:
Imgur Images Imgur Images

The maintainers will now check for:

  1. The number of Glyphs matches the number of SVGs that were selected.
  2. The icons (second group of pictures) look the same as the SVGs (first group of pictures).
  3. The icons are of high quality (legible, matches the official logo, etc.)
  4. A new object is added in the devicon.json file at the correct alphabetic position as seen here

In case of font issues, it might be caused by Icomoon not accepting strokes in the SVGs. Check this doc for more details and fix the issues as instructed by Icomoon and update this PR once you are done.

Thank you for contributing to Devicon! I hope that your icons are accepted into the repository.

Note: If the images don't show up, it has been autodeleted by Imgur after 6 months due to our API choice.

Cheers,
Peek Bot 😊

@weh weh merged commit b9e0f15 into devicons:develop Dec 19, 2025
5 checks passed
@sghng sghng deleted the starship branch December 19, 2025 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bot:check Trigger check-bot. Remove and re-add the label to re-trigger bot:peek Trigger peek-bot. Remove and re-add the label to re-trigger feature:icon PR when a new icon is ready to be added to the collection

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants