Skip to content

Fix missing DEBUG_PORT environment variable in Node.JS stack #121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

rm3l
Copy link
Member

@rm3l rm3l commented Sep 14, 2022

What does this PR do?:

This adds the missing DEBUG_PORT environment variable to the Node.JS stack. Otherwise, the debug command won't start when used with the starter project declared in this stack.
See devfile/api#929 for more details.

Which issue(s) this PR fixes:

Fixes devfile/api#929

PR acceptance criteria:

  • Contributing guide
    Have you read the devfile registry contributing guide and followed its instructions?
  • Test automation
    Does this repository's tests pass with your changes?
  • Documentation
    Does any documentation need to be updated with your changes?
  • Check Tools Provider
    Have you tested the changes with existing tools, i.e. Odo, Che, Console? (See devfile registry contributing guide on how to test changes)

How to test changes / Special notes to the reviewer:

I manually ran the tests/test.sh script (using odo 2.5.1) against both Minikube and OpenShift clusters.

@openshift-ci
Copy link

openshift-ci bot commented Sep 14, 2022

Hi @rm3l. Thanks for your PR.

I'm waiting for a devfile member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rm3l rm3l force-pushed the fix_missing_debug_port_envvar_in_nodejs_stack branch from 3adacec to ff99678 Compare September 14, 2022 07:45
@rm3l rm3l changed the title Fix missing DEBUG_PORT environment variable in Node.JS stack Fix missing DEBUG_PORT environment variable in Node.JS stack Sep 14, 2022
@openshift-ci openshift-ci bot added the lgtm Looks good to me label Sep 14, 2022
@rm3l
Copy link
Member Author

rm3l commented Sep 15, 2022

Any idea why the ci/prow/v4.7-registry-test check is not passing? I keep seeing this in the logs, but can't figure out why:

ERRO[2022-09-14T17:16:35Z] Some steps failed:                           
ERRO[2022-09-14T17:16:35Z] 
  * could not run steps: step registry-test failed: "registry-test" test steps failed: "registry-test" pod "registry-test-registry-test-steps" failed: the pod ci-op-j5cqcxvj/registry-test-registry-test-steps failed after 9s (failed containers: test): ContainerFailed one or more containers exited
Container test exited with code 1, reason Error

@johnmcollier
Copy link
Member

/retest

@rm3l rm3l force-pushed the fix_missing_debug_port_envvar_in_nodejs_stack branch from ff99678 to a07981c Compare September 22, 2022 20:06
@openshift-ci openshift-ci bot removed the lgtm Looks good to me label Sep 22, 2022
@rm3l
Copy link
Member Author

rm3l commented Sep 22, 2022

Had to rebase and force-push to check this PR against the new tests introduced in #102

@christoph-jerolimov
Copy link
Member

This is a "stack" and a Devfile 2.1, so from ODC side we don't support this so I can not help with a review here, right?

/uncc

@openshift-ci openshift-ci bot removed the request for review from christoph-jerolimov September 28, 2022 22:47
@rm3l rm3l force-pushed the fix_missing_debug_port_envvar_in_nodejs_stack branch from a07981c to 751363f Compare October 5, 2022 08:07
@johnmcollier
Copy link
Member

/retest

@johnmcollier
Copy link
Member

/ok-to-test

@rm3l rm3l force-pushed the fix_missing_debug_port_envvar_in_nodejs_stack branch from 751363f to 709511a Compare October 10, 2022 14:20
@openshift-ci
Copy link

openshift-ci bot commented Oct 10, 2022

@rm3l: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/v4.7-registry-test ff99678 link true /test v4.7-registry-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@johnmcollier
Copy link
Member

/retest

@rm3l rm3l force-pushed the fix_missing_debug_port_envvar_in_nodejs_stack branch from 709511a to 7896618 Compare October 21, 2022 08:06
@rm3l rm3l force-pushed the fix_missing_debug_port_envvar_in_nodejs_stack branch from 7896618 to 4850a66 Compare November 14, 2022 13:24
Copy link
Contributor

@elsony elsony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Looks good to me label Nov 14, 2022
@openshift-ci
Copy link

openshift-ci bot commented Nov 14, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BethGriggs, elsony, rm3l

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@elsony elsony merged commit 11829bd into devfile:main Nov 14, 2022
@rm3l rm3l deleted the fix_missing_debug_port_envvar_in_nodejs_stack branch November 14, 2022 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing DEBUG_PORT environment variable in nodejs stack
6 participants