-
Notifications
You must be signed in to change notification settings - Fork 93
Fix missing DEBUG_PORT
environment variable in Node.JS stack
#121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix missing DEBUG_PORT
environment variable in Node.JS stack
#121
Conversation
Hi @rm3l. Thanks for your PR. I'm waiting for a devfile member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
3adacec
to
ff99678
Compare
DEBUG_PORT
environment variable in Node.JS stack
Any idea why the
|
/retest |
ff99678
to
a07981c
Compare
Had to rebase and force-push to check this PR against the new tests introduced in #102 |
This is a "stack" and a Devfile 2.1, so from ODC side we don't support this so I can not help with a review here, right? /uncc |
a07981c
to
751363f
Compare
/retest |
/ok-to-test |
751363f
to
709511a
Compare
@rm3l: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/retest |
709511a
to
7896618
Compare
Signed-off-by: Armel Soro <[email protected]>
Signed-off-by: Armel Soro <[email protected]>
7896618
to
4850a66
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: BethGriggs, elsony, rm3l The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What does this PR do?:
This adds the missing
DEBUG_PORT
environment variable to the Node.JS stack. Otherwise, thedebug
command won't start when used with the starter project declared in this stack.See devfile/api#929 for more details.
Which issue(s) this PR fixes:
Fixes devfile/api#929
PR acceptance criteria:
Have you read the devfile registry contributing guide and followed its instructions?
Does this repository's tests pass with your changes?
Does any documentation need to be updated with your changes?
Have you tested the changes with existing tools, i.e. Odo, Che, Console? (See devfile registry contributing guide on how to test changes)
How to test changes / Special notes to the reviewer:
I manually ran the
tests/test.sh
script (using odo 2.5.1) against both Minikube and OpenShift clusters.