Fixed python debug and updated descriptions #117
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Paul Schultz <[email protected]>
BethGriggs
reviewed
Jul 13, 2022
| @@ -1,9 +1,9 @@ | |||
| schemaVersion: 2.1.0 | |||
| metadata: | |||
| name: nodejs | |||
| version: 1.0.1 | |||
There was a problem hiding this comment.
Shouldn't changing the underlying runtime version would be a semver-major bump?
Signed-off-by: Paul Schultz <[email protected]>
Signed-off-by: Paul Schultz <[email protected]>
johnmcollier
approved these changes
Jul 13, 2022
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: johnmcollier, schultzp2020 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Paul Schultz [email protected]
What does this PR do?:
Fixed python debug issue and updated descriptions
Which issue(s) this PR fixes:
Fixes devfile/api#876
Fixes devfile/api#883
PR acceptance criteria:
Have you read the devfile registry contributing guide and followed its instructions?
Does this repository's tests pass with your changes?
Does any documentation need to be updated with your changes?
Have you tested the changes with existing tools, i.e. Odo, Che, Console? (See devfile registry contributing guide on how to test changes)
How to test changes / Special notes to the reviewer: