update the PR template to clarify the requirement on tools provider check #104
Conversation
Signed-off-by: Stephanie <[email protected]>
.github/PULL_REQUEST_TEMPLATE.md
Outdated
| @@ -12,6 +12,8 @@ _Have you read the [devfile registry contributing guide](https://github.com/devf | |||
| _Does this repository's tests pass with your changes?_ | |||
| - [ ] Documentation | |||
| _Does any documentation need to be updated with your changes?_ | |||
| - [ ] Check Tools Provider | |||
| _Does this change impact existing tools, i.e. Odo, Che, Console? If it does, have you tested the change with those tools?_ | |||
There was a problem hiding this comment.
I wonder how the developer can answer this if they are not familiar with the impact of all of the tools. We may want to provide a link to provide more info on that so that the developer knows how to answer this question properly.
There was a problem hiding this comment.
talked with Tomas and Mario, they both suggest any change to registry need to be verified with tools to ensure it won't break tools. Reword the sentence to clarify the requirement to test with tools. Also updated the contributing.md to include instruction on how to test with existing tools providers.
|
/retest |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: elsony, yangcao77 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Stephanie [email protected]
What does this PR do?:
Summarize the changes. Are any stacks or samples added or updated?
update the PR template to include an additional check in PR acceptance criteria to clarify the requirement to check on tools
Which issue(s) this PR fixes:
Link to github issue(s)
Fixes devfile/api#814
PR acceptance criteria:
Have you read the devfile registry contributing guide and followed its instructions?
Does this repository's tests pass with your changes?
Does any documentation need to be updated with your changes?
How to test changes / Special notes to the reviewer: