Skip to content

Fix environment variable definitions for registry viewer deployment #160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 6, 2023
Merged

Fix environment variable definitions for registry viewer deployment #160

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 15 additions & 3 deletions deploy/chart/devfile-registry/templates/deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ spec:
name: {{ template "devfileregistry.fullname" . }}
items:
- key: .env.registry-viewer
path: .env.local
path: .env.production
containers:
- image: "{{ .Values.devfileIndex.image }}:{{ .Values.devfileIndex.tag }}"
imagePullPolicy: {{ .Values.devfileIndex.imagePullPolicy }}
Expand Down Expand Up @@ -133,10 +133,22 @@ spec:
memory: {{ .Values.registryViewer.memoryLimit }}
requests:
memory: 64Mi
env:
- name: ANALYTICS_WRITE_KEY
value: {{ .Values.telemetry.registryViewerWriteKey }}
- name: DEVFILE_REGISTRIES
value: |
[
{
"name": "Community",
"url": "http://localhost:8080",
"fqdn": "http://{{ .Release.Name }}-{{ .Release.Namespace }}.{{ .Values.global.ingress.domain }}"
}
]
volumeMounts:
- name: viewer-env-file
mountPath: /app/apps/registry-viewer/.env.local
subPath: .env.local
mountPath: /app/.env.production
subPath: .env.production
readOnly: true
securityContext:
allowPrivilegeEscalation: false
Expand Down