Skip to content

Conversation

michael-valdron
Copy link
Member

Please specify the area for this PR

What does does this PR do / why we need it:

Applies DCO file and changes to contribution guidelines and README in regards to issue devfile/api#878.

Which issue(s) this PR fixes:

Fixes #?

PR acceptance criteria:

  • Test (WIP)

Documentation (WIP)

How to test changes / Special notes to the reviewer:

@michael-valdron michael-valdron changed the title Dco Apply DCO to registry-support Sep 12, 2022
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 12, 2022
@openshift-ci
Copy link

openshift-ci bot commented Sep 12, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: michael-valdron, yangcao77
Once this PR has been reviewed and has the lgtm label, please assign maysunfaisal for approval by writing /assign @maysunfaisal in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@michael-valdron michael-valdron merged commit 25d4dc0 into devfile:main Sep 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants