chore: Set version of 'next' bundle to always update and add build info #815
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Configure the 'next' index image build to add incrementing prerelease identifiers and include the git-sha as the build identifier. E.g. for version v0.15.0-dev, build index images with versions v0.15.0-dev.0+59b2f40e v0.15.0-dev.1+ca15cf09 v0.15.0-dev.2+bd17527a To ensure clusters deploying the 'next' catalog will always update to new builds. Note the semantics for version comparison in SemVer are: * Build identifiers are ignored (e.g. +59b2f40e) * Each dot-separated segment of a prerelease identifier is compared: * if alphanumeric, lexically in ASCII sort order * if only digits, numerically * numeric identifiers < alphanumeric identifiers Signed-off-by: Angel Misevski <[email protected]>
3 tasks
ibuziuk
approved these changes
Apr 13, 2022
ibuziuk
approved these changes
Apr 13, 2022
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: amisevsk, ibuziuk The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Configure the 'next' index image build to add incrementing prerelease identifiers and include the git-sha as the build identifier. E.g. for version v0.15.0-dev, build index images with versions
v0.15.0-dev.0+59b2f40e
v0.15.0-dev.1+ca15cf09
v0.15.0-dev.2+bd17527a
To ensure clusters deploying the 'next' catalog will always update to
new builds.
Note the semantics for version comparison in SemVer are:
What issues does this PR fix or reference?
Closes #814
Is it tested? How?
Tested in my fork, see recent runs of the
test.ymllworkflow: https://github.com/amisevsk/devworkspace-operator/actions/workflows/test.ymlI've also tested
crc: with the versioning scheme used here, new changes are automatically rolled out and new DWO images are pulled (technically each one is a new version of DWO)PR Checklist
/test v8-devworkspace-operator-e2e, v8-che-happy-pathto trigger)v8-devworkspace-operator-e2e: DevWorkspace e2e testv8-che-happy-path: Happy path for verification integration with Che