update default value description for new autobuild and deploybydefault #718
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Stephanie <[email protected]>
yangcao77
requested review from
amisevsk,
davidfestal and
sleshchenko
as code owners
4 tasks
kim-tsao
reviewed
Jan 5, 2022
| description: Defines if the image should be built during | ||
| startup Default is false | ||
| description: "Defines if the image should be built during | ||
| startup \n Default value is `false`" |
There was a problem hiding this comment.
Sorry for the nitpick but I know these descriptions make it in the doc. Can we end the sentence after the word startup with a "."
Signed-off-by: Stephanie <[email protected]>
yangcao77
force-pushed
the
693-apply-boolean-default
branch
from
9df17d9 to
b6877c1
Compare
Signed-off-by: Stephanie <[email protected]>
kim-tsao
approved these changes
Jan 5, 2022
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: kim-tsao, yangcao77 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?:
update default value description for new
autoBuildanddeployByDefaultto make it consistent with other boolean values, as requested by devfile/library#127 (comment)Which issue(s) this PR fixes:
#693
PR acceptance criteria:
Testing and documentation do not need to be complete in order for this PR to be approved. We just need to ensure tracking issues are opened.
Unit/Functional tests
QE Integration test
Documentation
Client Impact
How to test changes / Special notes to the reviewer: