Skip to content

reduce endpoint name length limitation to 15 chars, validate on port duplication #702

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jan 17, 2022
Merged

reduce endpoint name length limitation to 15 chars, validate on port duplication #702

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
819b6b4
update validation & schema
yangcao77 Dec 7, 2021
b805105
fix build error
yangcao77 Dec 8, 2021
a4e0b0b
Merge branch 'main' of github.com:devfile/api into 700-ReduceEndpoint…
yangcao77 Jan 13, 2022
1c45bd1
update generater to only shorten endpoint name length limit in devfil…
yangcao77 Jan 14, 2022
436f865
fix api test
yangcao77 Jan 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions crds/workspace.devfile.io_devworkspaces.v1beta1.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -454,6 +454,7 @@ spec:
`wss`.
type: boolean
targetPort:
description: The port number should be unique.
type: integer
required:
- name
Expand Down Expand Up @@ -751,6 +752,7 @@ spec:
`wss`.
type: boolean
targetPort:
description: The port number should be unique.
type: integer
required:
- name
Expand Down Expand Up @@ -869,6 +871,7 @@ spec:
`wss`.
type: boolean
targetPort:
description: The port number should be unique.
type: integer
required:
- name
Expand Down Expand Up @@ -1259,6 +1262,8 @@ spec:
a protocol of `https` or `wss`.
type: boolean
targetPort:
description: The port number should be
unique.
type: integer
required:
- name
Expand Down Expand Up @@ -1552,6 +1557,8 @@ spec:
a protocol of `https` or `wss`.
type: boolean
targetPort:
description: The port number should be
unique.
type: integer
required:
- name
Expand Down Expand Up @@ -1681,6 +1688,8 @@ spec:
a protocol of `https` or `wss`.
type: boolean
targetPort:
description: The port number should be
unique.
type: integer
required:
- name
Expand Down Expand Up @@ -2166,6 +2175,7 @@ spec:
or `wss`.
type: boolean
targetPort:
description: The port number should be unique.
type: integer
required:
- name
Expand Down Expand Up @@ -2442,6 +2452,7 @@ spec:
or `wss`.
type: boolean
targetPort:
description: The port number should be unique.
type: integer
required:
- name
Expand Down Expand Up @@ -2561,6 +2572,7 @@ spec:
or `wss`.
type: boolean
targetPort:
description: The port number should be unique.
type: integer
required:
- name
Expand Down Expand Up @@ -2965,6 +2977,8 @@ spec:
or `wss`.
type: boolean
targetPort:
description: The port number should
be unique.
type: integer
required:
- name
Expand Down Expand Up @@ -3276,6 +3290,8 @@ spec:
or `wss`.
type: boolean
targetPort:
description: The port number should
be unique.
type: integer
required:
- name
Expand Down Expand Up @@ -3412,6 +3428,8 @@ spec:
or `wss`.
type: boolean
targetPort:
description: The port number should
be unique.
type: integer
required:
- name
Expand Down
18 changes: 18 additions & 0 deletions crds/workspace.devfile.io_devworkspaces.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -462,6 +462,7 @@ spec:
or `wss`.
type: boolean
targetPort:
description: The port number should be unique.
type: integer
required:
- name
Expand Down Expand Up @@ -764,6 +765,7 @@ spec:
or `wss`.
type: boolean
targetPort:
description: The port number should be unique.
type: integer
required:
- name
Expand Down Expand Up @@ -885,6 +887,7 @@ spec:
or `wss`.
type: boolean
targetPort:
description: The port number should be unique.
type: integer
required:
- name
Expand Down Expand Up @@ -1282,6 +1285,8 @@ spec:
`wss`.
type: boolean
targetPort:
description: The port number should
be unique.
type: integer
required:
- name
Expand Down Expand Up @@ -1583,6 +1588,8 @@ spec:
`wss`.
type: boolean
targetPort:
description: The port number should
be unique.
type: integer
required:
- name
Expand Down Expand Up @@ -1715,6 +1722,8 @@ spec:
`wss`.
type: boolean
targetPort:
description: The port number should
be unique.
type: integer
required:
- name
Expand Down Expand Up @@ -2203,6 +2212,7 @@ spec:
protocol of `https` or `wss`.
type: boolean
targetPort:
description: The port number should be unique.
type: integer
required:
- name
Expand Down Expand Up @@ -2484,6 +2494,7 @@ spec:
protocol of `https` or `wss`.
type: boolean
targetPort:
description: The port number should be unique.
type: integer
required:
- name
Expand Down Expand Up @@ -2605,6 +2616,7 @@ spec:
protocol of `https` or `wss`.
type: boolean
targetPort:
description: The port number should be unique.
type: integer
required:
- name
Expand Down Expand Up @@ -3017,6 +3029,8 @@ spec:
of `https` or `wss`.
type: boolean
targetPort:
description: The port number should
be unique.
type: integer
required:
- name
Expand Down Expand Up @@ -3332,6 +3346,8 @@ spec:
of `https` or `wss`.
type: boolean
targetPort:
description: The port number should
be unique.
type: integer
required:
- name
Expand Down Expand Up @@ -3471,6 +3487,8 @@ spec:
of `https` or `wss`.
type: boolean
targetPort:
description: The port number should
be unique.
type: integer
required:
- name
Expand Down
15 changes: 15 additions & 0 deletions crds/workspace.devfile.io_devworkspacetemplates.v1beta1.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -419,6 +419,7 @@ spec:
This requires a protocol of `https` or `wss`.
type: boolean
targetPort:
description: The port number should be unique.
type: integer
required:
- name
Expand Down Expand Up @@ -710,6 +711,7 @@ spec:
This requires a protocol of `https` or `wss`.
type: boolean
targetPort:
description: The port number should be unique.
type: integer
required:
- name
Expand Down Expand Up @@ -822,6 +824,7 @@ spec:
This requires a protocol of `https` or `wss`.
type: boolean
targetPort:
description: The port number should be unique.
type: integer
required:
- name
Expand Down Expand Up @@ -1202,6 +1205,7 @@ spec:
protocol of `https` or `wss`.
type: boolean
targetPort:
description: The port number should be unique.
type: integer
required:
- name
Expand Down Expand Up @@ -1483,6 +1487,7 @@ spec:
protocol of `https` or `wss`.
type: boolean
targetPort:
description: The port number should be unique.
type: integer
required:
- name
Expand Down Expand Up @@ -1604,6 +1609,7 @@ spec:
protocol of `https` or `wss`.
type: boolean
targetPort:
description: The port number should be unique.
type: integer
required:
- name
Expand Down Expand Up @@ -2071,6 +2077,7 @@ spec:
`wss`.
type: boolean
targetPort:
description: The port number should be unique.
type: integer
required:
- name
Expand Down Expand Up @@ -2340,6 +2347,7 @@ spec:
`wss`.
type: boolean
targetPort:
description: The port number should be unique.
type: integer
required:
- name
Expand Down Expand Up @@ -2457,6 +2465,7 @@ spec:
`wss`.
type: boolean
targetPort:
description: The port number should be unique.
type: integer
required:
- name
Expand Down Expand Up @@ -2846,6 +2855,8 @@ spec:
a protocol of `https` or `wss`.
type: boolean
targetPort:
description: The port number should be
unique.
type: integer
required:
- name
Expand Down Expand Up @@ -3139,6 +3150,8 @@ spec:
a protocol of `https` or `wss`.
type: boolean
targetPort:
description: The port number should be
unique.
type: integer
required:
- name
Expand Down Expand Up @@ -3268,6 +3281,8 @@ spec:
a protocol of `https` or `wss`.
type: boolean
targetPort:
description: The port number should be
unique.
type: integer
required:
- name
Expand Down
Loading