Skip to content

Update metadata icon desc #460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 14, 2021
Merged

Update metadata icon desc #460

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pkg/devfile/header.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ type DevfileMetadata struct {
// +optional
Tags []string `json:"tags,omitempty"`

// Optional devfile icon
// Optional devfile icon, can be a URI or a relative path in the project
// +optional
Icon string `json:"icon,omitempty"`

Expand Down
2 changes: 1 addition & 1 deletion schemas/latest/devfile.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -654,7 +654,7 @@
"type": "string"
},
"icon": {
"description": "Optional devfile icon",
"description": "Optional devfile icon, can be a URI or a relative path in the project",
"type": "string"
},
"language": {
Expand Down
4 changes: 2 additions & 2 deletions schemas/latest/ide-targeted/devfile.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -721,9 +721,9 @@
"markdownDescription": "Optional devfile global memory limit"
},
"icon": {
"description": "Optional devfile icon",
"description": "Optional devfile icon, can be a URI or a relative path in the project",
"type": "string",
"markdownDescription": "Optional devfile icon"
"markdownDescription": "Optional devfile icon, can be a URI or a relative path in the project"
},
"language": {
"description": "Optional devfile language",
Expand Down