Skip to content

remove github support from project #442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from

Conversation

yangcao77
Copy link
Contributor

Signed-off-by: Stephanie [email protected]

What does this PR do?

This PR removes project.Github and all github related types

What issues does this PR fix or reference?

#340

Is your PR tested? Consider putting some instruction how to test your changes

Docs PR

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: yangcao77

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@yangcao77 yangcao77 force-pushed the 340-removeGithuSupport branch from dfeb734 to 9128d2c Compare April 27, 2021 17:45
@yangcao77 yangcao77 force-pushed the 340-removeGithuSupport branch from 9128d2c to dab2efc Compare April 27, 2021 17:59
Signed-off-by: Stephanie <[email protected]>
@yangcao77
Copy link
Contributor Author

closing this pr since it's duplicated of #439
created a pull request in Angel's fork instead, to help fix the test failures: amisevsk#1

@yangcao77 yangcao77 closed this Apr 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants