Skip to content

Investigate API's generator potential improvements #1359

Closed as not planned
Closed as not planned
@thepetk

Description

@thepetk

Which area/kind this issue is related to?

/area api

Issue Description

As seen in the #1345 after the upgrade to go 1.19 the generator module is now using the -mod=mod while having a fixed version of the sigs.k8s.io/controller-tools/cmd/helpgen package. For example it generates the code through:

go:generate go run -mod=mod sigs.k8s.io/controller-tools/cmd/helpgen@v0.6.2 
generate:headerFile=../header.go.txt,year=2020 paths=.

As a result, this update skips the usage of vendor directory for this dependency. As part of this issue we should investigate any potential workarounds on how we can generate the code while using only the vendor directory.

Acceptance Criteria

  • Investigate any potential workaround on using go generate with the usage only of vendor dir.

Metadata

Metadata

Assignees

No one assigned

    Labels

    area/apiEnhancement or issue related to the api/devfile specificationlifecycle/rottenRotten items. These items have been stale for 60 days and are now closed.lifecycle/staleStale items. These items have not been updated for 90 days.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions