Skip to content

Integration test container should have a wait condition #1086

@michael-valdron

Description

@michael-valdron

Which area this feature is related to?

/kind bug

Which area this bug is related to?

/area ci
/area registry
/area integration-tests

What versions of software are you using?

Go project

Operating System and version: N/A

Go Pkg Version: 1.18

Bug Summary

Describe the bug:

The acceptance tests after staging is deployed are failing due to the tests running before the registry viewer container is ready (could take up to the timeout time of 20 seconds). The default run command for the integration test container performs the tests without waiting for the tied devfile registry deployment to enter the available state.

To Reproduce:

Any triggering of staging at this point could lead to the acceptance tests executing before the devfile registry deployment is available to be tested on.

Expected behavior

Any logs, error output, screenshots etc? Provide the devfile that sees this bug, if applicable

Summarizing 1 Failure:
[Fail] [Verify index server is working properly] [It] /viewer should serve the registry viewer
/registry-test/pkg/tests/indexserver_tests.go:76
Ran 30 of 41 Specs in 7.646 seconds
FAIL! -- 29 Passed | 1 Failed | 0 Pending | 11 Skipped
--- FAIL: TestDevfileRegistryController (7.65s)
FAIL

Additional context

Any workaround?

No workaround can be done for this issue.

Suggestion on how to fix the bug

The entrypoint for the integration tests Dockerfile needs to be modified to allow the specification of a wait condition and timeout.

Registry health check probing would ensure target registry is ready before running tests.

Target Date: 04-03-2023

Metadata

Metadata

Labels

area/ciarea/integration-testsEnhancement or issue related to the devfile integration testsarea/registryDevfile registry for stacks and infrastructurekind/bugSomething isn't working

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions