Change controller-runtime version to v0.14.7 #35
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: thepetk <[email protected]>
thepetk
requested review from
johnmcollier,
michael-valdron,
maysunfaisal and
kim-tsao
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #35 +/- ##
=======================================
Coverage ? 70.49%
=======================================
Files ? 11
Lines ? 1566
Branches ? 0
=======================================
Hits ? 1104
Misses ? 395
Partials ? 67 ☔ View full report in Codecov by Sentry. |
maysunfaisal
reviewed
Nov 9, 2023
maysunfaisal
approved these changes
Nov 9, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: maysunfaisal, thepetk The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR changes the version of
controller-runtimefromv0.15.0tov0.14.7for two reasons:v0.14.7uses thegolang.org/x/net v0.17.0while thev0.15.0uses thegolang.org/x/net v0.11.0.controller-runtimewith HAS, one of the main consumers of alizer. The HAS controller runtime dependency can be found here: https://github.com/redhat-appstudio/application-service/blob/main/go.mod#L35Which issue(s) does this PR fix
fixes devfile/api#1304
PR acceptance criteria
Testing and documentation do not need to be complete in order for this PR to be approved. We just need to ensure tracking issues are opened.
Unit/Functional tests
Documentation
How to test changes / Special notes to the reviewer